Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes of the pull request:
Fix design problem with$\rho$ values for preconditioned FGMRES, save the values as an instance variable.
multi_shift_fomandmulti_shift_fgmres. Instead of returningSort shifts in
multi_shift_fgmres. Sorting shifts in GMRES can improve convergence, see e.g. https://doi.org/10.1137/S1064827596304563.Smaller restart size for tests of
multi_shift_fomandmulti_shift_fgmres. By using a smaller restart size, shifts can converge at different iterations. This change allows for testing the handling of already converged shifts.